[CI] Remove draft release CI step#666
Open
nvaytet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The draft release step when making a release goes wrong when we make a release via the web UI.
A draft release with the same name using the same tag is created alongside the release already created by the web UI.
Then, the release notes of the non-draft release get updated.
The uploading of the docs as assets fails.
The draft release never gets promoted to non-draft, because the original release gets picked up by the
ghcommand.For now, we remove this step, meaning that releases should only be created via the web interface (simply pushing a tag from the CLI will no longer work).
We should revisit once everyone is back from vacation.