Skip to content

[CI] Set environment variable in the draft release job #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YooSunYoung merged 6 commits into from
Jul 1, 2026
Merged

[CI] Set environment variable in the draft release job #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
243ce68
Set environment variable in the draft release job
YooSunYoung Jun 30, 2026
629fd68
Update draft-release dependencies in workflow
YooSunYoung Jun 30, 2026
5904366
Remove full changelog link from release notes
YooSunYoung Jun 30, 2026
23e8567
Remove empty string from release notes
YooSunYoung Jun 30, 2026
fe64151
Checkout before drafting a release.
YooSunYoung Jun 30, 2026
64422fc
Add condition to draft-release job for tag events
YooSunYoung Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,17 @@ jobs:

draft-release:
name: Draft a release or/and check the release
needs: [ determine-package, publish ]
needs: [ determine-package ]
runs-on: ubuntu-slim
if: ${{ startsWith(github.ref, 'refs/tags/') && github.event_name != 'workflow_dispatch' }}
permissions:
contents: write
env:
TAG: ${{ needs.determine-package.outputs.package }}/${{ needs.determine-package.outputs.version }}
GH_TOKEN: ${{ github.token }}
steps:
- uses: actions/checkout@v6
- name: Draft a release.
env:
GH_TOKEN: ${{ github.token }}
run: gh release create ${TAG} --draft --title ${TAG} # Default title is not always the tag name.
continue-on-error: true # Release create can fail if there is an existing release.
- name: Check the release.
Expand Down
9 changes: 0 additions & 9 deletions tools/collect-release-notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,6 @@ def has_label(label: str, pr: PRDescription) -> bool:
[f"* {relevant_log}" for relevant_log in maybe_relevant_logs]
)

release_note.extend(
[
'',
'',
f"**Full Changelog**: https://github.com/scipp/ess/compare/{compare_tag}...{cur_tag}",
'',
]
)

Comment on lines -119 to -127

@YooSunYoung YooSunYoung Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compare tags container too many unrelated commits so we decided to remove it for now.

if hasattr(args, 'output_file_path') and args.output_file_path:
output_file_path = pathlib.Path(args.output_file_path)
else:
Expand Down