Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions RELEASING.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Releasing the SchemaLock Zed extension

The extension versions independently of `schemalock/app`. `.app-version` and the
The extension versions independently of `schemalock/schemalock`. `.app-version` and the
`APP_VERSION` const in `src/lib.rs` pin which app tag the extension downloads;
they must always match.

> **Why the CDN, not GitHub releases?** `schemalock/app` is a **private** repo, so
> Zed's anonymous GitHub API calls 404. The extension instead downloads from the
> public CDN at `https://cdn.schemalock.dev/bin/<tag>/<asset>`. Publishing those
> **Why the CDN, not GitHub releases?** The binaries are published to the CDN by
> the app release pipeline, and the WASM sandbox has no GitHub API credentials. The
> extension downloads from the public CDN at `https://cdn.schemalock.dev/bin/<tag>/<asset>`. Publishing those
> objects is part of the app release (see "Publishing binaries to the CDN" below).

## Bumping the pinned app version
Expand All @@ -27,7 +27,7 @@ they must always match.
5. Branch + merge (never commit directly to the default branch) + tag the
extension at the new version.

> Schema/protocol changes in `schemalock/app` are contract-breaking. Ship the app
> Schema/protocol changes in `schemalock/schemalock` are contract-breaking. Ship the app
> bump and the extension bump in lockstep so `.app-version` always points at a
> compatible app.

Expand Down
2 changes: 1 addition & 1 deletion core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub struct Platform {
/// Returns the GitHub release asset name for `platform`, or `None` if SchemaLock
/// publishes no prebuilt binary for that os/arch combination.
///
/// Asset names are the exact `schemalock/app` release asset filenames.
/// Asset names are the exact `schemalock/schemalock` release asset filenames.
pub fn asset_name(platform: &Platform) -> Option<&'static str> {
match (platform.os, platform.arch) {
("mac", "aarch64") => Some("schemalock-darwin-arm64"),
Expand Down
6 changes: 3 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@

use zed_extension_api::{self as zed, LanguageServerId, Result};

/// The pinned `schemalock/app` release tag whose binary this extension version
/// The pinned `schemalock/schemalock` release tag whose binary this extension version
/// ships against. Keep in lockstep with the `.app-version` file (the file is the
/// human-facing source of truth; this const is what actually drives the
/// download, because the WASM sandbox cannot read repo files at runtime).
const APP_VERSION: &str = "v0.3.2";

/// Public CDN prefix under which the per-tag binaries are published. The full
/// asset URL is `<CDN_BASE>/<APP_VERSION>/<asset>`. We download straight from the
/// CDN (not the GitHub API) because `schemalock/app` is a private repository —
/// only the binaries are public.
/// CDN (not the GitHub API): the binaries are published to the CDN by the app
/// release pipeline, and the WASM sandbox has no GitHub API credentials.
const CDN_BASE: &str = "https://cdn.schemalock.dev/bin";

struct SchemaLockExtension;
Expand Down