perf: eliminate redundant getHash calls in HashMap/HashSet concat#26278
Open
He-Pin wants to merge 1 commit into
Open
perf: eliminate redundant getHash calls in HashMap/HashSet concat#26278He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Motivation: In BitmapIndexedMapNode.concat and BitmapIndexedSetNode.concat, the leftNodeRightData branch calls bm.getHash(rightDataIdx) twice: once to store in rightOriginalHash, and again as the originalHash argument to updated(). The second call is redundant since the value is already available. Modification: Replace the second bm.getHash(rightDataIdx) with rightOriginalHash in both HashMap and HashSet concat implementations. Result: Eliminates one redundant array access per right-side data element during concat operations in the leftNodeRightData branch.
SolalPirelli
approved these changes
Jun 9, 2026
SolalPirelli
left a comment
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I'm good with this as a cleanup regardless of perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminate redundant getHash calls in HashMap/HashSet concat.
Problem
In BitmapIndexedMapNode.concat and BitmapIndexedSetNode.concat, the leftNodeRightData branch calls bm.getHash(rightDataIdx) twice: once to store in rightOriginalHash, and again as the originalHash argument to updated(). The second call is redundant since the value is already available.
Solution
Replace the second bm.getHash(rightDataIdx) with rightOriginalHash in both HashMap and HashSet concat implementations.
Result
Eliminates one redundant array access per right-side data element during concat operations in the leftNodeRightData branch.
LLM Policy
LLM-based tools were used extensively in this contribution. The code was reviewed and tested locally before submission.