filter_map_next: clean-up, overhaul suggestions#17237
Open
ada4a wants to merge 6 commits into
Open
Conversation
i.e. rename: - filter_map_next -> filter_map_next_unfixable - filter_map_next_fixable -> filter_map_next This is because having fixable lints is the common case
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
ada4a
force-pushed
the
cleanup-filter_map_next
branch
from
62f2e9b to
85ae0cd
Compare
separate commit to improve diffs
1. In the singe-line case, we switch to verbose suggestions, otherwise the suggestion line gets too long due to the longer message. 2. In the multi-line case, we use span-less help, otherwise the whole multiline span gets highlighted the second time. 3. Also make the suggestion message more concise.
This used to be a workaround for a rustc diagnostics issue which has since been resolved
ada4a
force-pushed
the
cleanup-filter_map_next
branch
from
85ae0cd to
30994a7
Compare
|
Lintcheck changes for 30994a7
This comment will be updated if you push new changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
filter_map_next]: overhaul suggestions