Update real-loot-key-value to 1.0.0 version#12650
Open
pk-enjoyer wants to merge 1 commit into
Open
Conversation
|
|
|
Internal use only: Reviewer details Maintainer details |
Contributor
Author
|
Oke, ill update the README pictures in another pr, i cba for now. Plus it allows me to get some candid screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin now makes beter use of the runelite API, the compact keys no longer overlays the loot chest UI at the top. It instead just calls the API and changes the value (It also saves the original displayed osrs value, so it can be reverted when the plugin is switched off).
This also fixes an issue with other plugins that change the UI, our overlay would just overlay 'ugly' brown Runescape background over the no longer brown UI.
That said, the "top right" version of the plugin still does this... not sure if ill ever make this pretty.
- [ ] Fix the pictures in the README, as the old repo was deleted, meaning that the pictures url are now broken : (