fix ROSspinThread shutdown data race and prune unloaded instances#361
Open
ahcorde wants to merge 3 commits into
Open
fix ROSspinThread shutdown data race and prune unloaded instances#361ahcorde wants to merge 3 commits into
ahcorde wants to merge 3 commits into
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
asymingt
reviewed
Jun 29, 2026
| { | ||
| if (ros_spin_thread_ != nullptr) { | ||
| ros_spin_thread_->abort = true; | ||
| ros_spin_thread_->abort.store(true, std::memory_order_relaxed); |
There was a problem hiding this comment.
In the title of this PR you suggest that the addition of this line prevents a data race. However, the std::memory_order_relaxed actually adds no guardrails when it comes to compiler optimizations reordering instructions and breaking thread safety.
Why did you choose this in stead of std::memory_order_seq_cst?
Contributor
Author
There was a problem hiding this comment.
both solution are equivalent in this case.
…ce' into ahcorde/rolling/rosspinthread_daterace
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix ROSspinThread shutdown data race and prune unloaded instances