Use the same Qt version as qt_gui_cpp#346
Draft
cottsay wants to merge 1 commit into
Draft
Conversation
Rather than running the detection logic again, just use the version that qt_gui_cpp used, which we must match. Signed-off-by: Scott K Logan <logans@cottsay.net>
sloretz
approved these changes
Apr 28, 2026
mjcarroll
approved these changes
May 28, 2026
ahcorde
requested changes
May 28, 2026
ahcorde
left a comment
ahcorde
left a comment
Contributor
There was a problem hiding this comment.
CMake defaults to ascending resolution, so when Qt5 and Qt6 are both present, Qt5 will be found first when Qt6 is desired (Rolling, L-Turtle, and beyond). e.g. this pattern find_package(QT NAMES Qt6 Qt5 ...) resolves to Qt5.
Reference ros2/rviz#1689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than running the detection logic again, just use the version that qt_gui_cpp used, which we must match.