Skip to content

DDC: stop crash on volume change with DDC output #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maleadt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DDC: stop crash on volume change with DDC output #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions FineTune/Audio/DDC/DDCController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,16 @@ final class DDCController {
settingsManager.setDDCVolume(for: uid, to: clamped)
}

// Debounce DDC write
// Keep the work item @Sendable and avoid `self`; otherwise it inherits
// @MainActor isolation here and traps when run on `ddcQueue`.
debounceTimers[deviceID]?.cancel()
let service = services[deviceID]
let item = DispatchWorkItem { [weak self] in
let logger = self.logger
let item = DispatchWorkItem { @Sendable in
do {
try service?.setAudioVolume(clamped)
} catch {
self?.logger.error("DDC write failed for device \(deviceID): \(error)")
logger.error("DDC write failed for device \(deviceID): \(error)")
}
}
debounceTimers[deviceID] = item
Expand Down