feat(settings): auto-switch to newly connected outputs#227
Open
XiaKaiYang wants to merge 1 commit into
Open
Conversation
|
Super feature, I need it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Auto-Switch New Outputaudio setting so newly connected output devices can become the active output immediately when the user wants that behaviorWhy
FineTune currently only auto-switches to a connected output when that device is already the highest-priority device. Newly seen outputs are appended to the end of the priority list, so common cases like plugging in headphones require a manual menu bar selection every time.
Impact
Validation
xcodebuild test -project /Users/xiakaiyang/WeChatReplyAssistant/tmp/FineTune/FineTune.xcodeproj -scheme FineTune -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY='' -only-testing:FineTuneTests/OutputDeviceAutoSwitchTestsxcodebuild test -project /Users/xiakaiyang/WeChatReplyAssistant/tmp/FineTune/FineTune.xcodeproj -scheme FineTune -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY='' -only-testing:FineTuneTests/SettingsJSONTests -only-testing:FineTuneTests/AppSettingsDefaultTests