Fix salt association across WAL boundary.#322
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the WriteAhead class in src/examples/WriteAhead.js to adjust the handling of the waSalt1 property within transactions. Specifically, it initializes waSalt1 with a placeholder value, ensures it is correctly assigned from the active header during frame processing and transaction finalization, and updates a code comment for clarity. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #320.
When loading a transaction from the WAL, if the load starts on one WAL file, reads the end record, and moves to the other WAL file, then the wrong file identifier (the waSalt1 property) was set on all the pages on that transaction. This could cause reads from the wrong WAL file which would appear as database corruption errors.