Fix CE URL scheme routing#101
Draft
baron wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #77.
This fixes the RepoPrompt CE URL-scheme productization mismatch by making
repoprompt-ce://the canonical app deep-link scheme while preserving parser-level compatibility for legacyrepoprompt://URLs that are delivered to CE.What changed
AppDeepLinkURLScheme.repoprompt-ce://.Why
RepoPrompt CE registers
repoprompt-cein its app bundle, but routing code was still expecting and generatingrepoprompt. That meant LaunchServices could deliver a valid CE URL to the app and the app would ignore it before reaching the opener path.Validation
.agents/skills/rpce-contribution-check/scripts/preflight.sh commitpython3 Scripts/test_release_tooling.py -k test_info_plist_registers_canonical_ce_url_scheme_onlymake dev-lintmake dev-test FILTER=AppPlatformUtilityRecoveryTestsmake dev-swift-build PRODUCT=RepoPromptmake dev-testmake dev-test FILTER=AgentModeChatSwitchActivationTestsafter one transient full-suite failure in that unrelated suite.agents/skills/rpce-contribution-check/scripts/preflight.sh pushpassed on retry