Fix for #738#841
Open
harismh wants to merge 4 commits into
Open
Conversation
GET requests like for Swagger do not have content-type set, causing #(encoder %) to eventually call a nil function. Encoder is now a noop if formatter is nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #738. Root cause was not swagger code itself, but local GET requests to swagger not having Content-Type set.
encode-plain-valuethen calls a nil function, causing the crash. Fix was to make the encoder a noop if nil. Added basic tests to better catch swagger issues in the future.Note: Had to run
codegen-javabefore runningbb http-server-uberon a first clone. I addedjcompileas build dependency tohttp-server-jcompileto workaround that.Checks
Bugfix
fixes #numberFeature
fixes #numberADDITIONAL INFORMATION
New tests pass. Original reproduction is fixed too.