fix(siwx): preserve unrelated local storage sessions on delete - #5737
Open
grandpig wants to merge 1 commit into
Open
fix(siwx): preserve unrelated local storage sessions on delete#5737grandpig wants to merge 1 commit into
grandpig wants to merge 1 commit into
Conversation
Signed-off-by: grandpig <grandpig@outlook.com>
🦋 Changeset detectedLatest commit: 76019e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@grandpig is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
All contributors have signed the CTA ✍️ ✅ |
hilljessica8787-dot
approved these changes
Aug 4, 2026
Author
|
I have read the CTA Document and I hereby sign the CTA |
Author
|
@hilljessica8787-dot Thank you for your approval. Signed. |
Author
|
It seems that the CI failure is unrelated to this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
LocalStorage.delete()in the SIWX package so that it only removes sessions matching both the requested chain ID and account address.The existing filter uses:
This unintentionally removes unrelated sessions when either the chain ID or account address matches.
For example, deleting
(eip155:1, 0xAAA)also removes:(eip155:1, 0xBBB)(eip155:137, 0xAAA)The filter now uses
||, preserving every session except those matching both identifiers.Regression coverage verifies that:
Type of change
Associated Issues
N/A — small, self-contained bug fix.
Showcase (Optional)
N/A — no UI changes.
Checklist