Skip to content

fix: add SNI servername for TLS connection from host field #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougEfresh wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −1
Open

fix: add SNI servername for TLS connection from host field #2105

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
461c4cc
fix: add SNI servername for TLS connection from host field if not exp…
dougEfresh Apr 20, 2026
ce668d2
fix: check if host isIp
dougEfresh Apr 20, 2026
61db0c1
fix: add unit tests
dougEfresh Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/connectors/StandaloneConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export default class StandaloneConnector extends AbstractConnector {

if (options.tls) {
Object.assign(connectionOptions, options.tls);
if ("host" in connectionOptions && !("servername" in connectionOptions)) {
(connectionOptions as any).servername = (connectionOptions as TcpOptions).host;
}
Comment thread
cursor[bot] marked this conversation as resolved.
}
Comment on lines 42 to 50

@matheusvellone matheusvellone Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the tls.servername even when tls is undefined would be a good improvement.

In my case, where I'm using only the tls.servername, I would need to set an empty tls: {} to trigger this servername logic, which would be kinda weird.

I believe setting the servername for non-TLS connections isn't a breaking change, right?


// TODO:
Expand Down
Loading