chore(deps): Bump github.com/moby/buildkit from 0.25.1 to 0.28.1 in /mcv#117
Open
dependabot[bot] wants to merge 5 commits into
Open
chore(deps): Bump github.com/moby/buildkit from 0.25.1 to 0.28.1 in /mcv#117dependabot[bot] wants to merge 5 commits into
dependabot[bot] wants to merge 5 commits into
Conversation
Collaborator
|
@dependabot help |
Collaborator
|
@dependabot recreate |
45d9351 to
95c1260
Compare
Collaborator
|
https://github.com/dependabot recreate |
Bumps [github.com/moby/buildkit](https://github.com/moby/buildkit) from 0.25.1 to 0.28.1. - [Release notes](https://github.com/moby/buildkit/releases) - [Commits](moby/buildkit@v0.25.1...v0.28.1) --- updated-dependencies: - dependency-name: github.com/moby/buildkit dependency-version: 0.28.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
95c1260 to
4b5349a
Compare
ebb1e6b to
3b8aebd
Compare
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
3b8aebd to
eb4327c
Compare
The buildkit v0.28.1 update pulls in cyphar/filepath-securejoin v0.6.0, which moved OpenInRoot and Reopen functions to the pathrs-lite subpackage. The vendored go.podman.io/storage v1.62.0 code still imports the main package but calls these functions, causing build failures. Add a sed patch in the Makefile tidy-vendor target to fix the import path after vendoring. Fixes build errors: - vendor/go.podman.io/storage/userns.go:334:29: undefined: securejoin.OpenInRoot - vendor/go.podman.io/storage/userns.go:340:20: undefined: securejoin.Reopen Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The buildkit v0.28.1 upgrade pulls in cyphar/filepath-securejoin v0.6.0, which moved OpenInRoot and Reopen functions from the main package to the pathrs-lite subpackage. The vendored go.podman.io/storage v1.62.0 still imports the main package causing build failures. Changes: - Patch vendor/go.podman.io/storage/userns.go import path - Update Makefile vendors target to apply patch after go mod vendor - Update mcv/Makefile tidy-vendor target to apply patch - Update .github/workflows/mcv-build.yml to use make tidy-vendor This ensures the patch is applied both locally and in CI, fixing: - vendor/go.podman.io/storage/userns.go:334: undefined: securejoin.OpenInRoot - vendor/go.podman.io/storage/userns.go:340: undefined: securejoin.Reopen Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Downgrade storage and related dependencies to resolve compatibility issue with filepath-securejoin. The newer storage v1.62.0 requires OpenatInRoot and Reopen functions that aren't exported in the main filepath-securejoin package until a future release. Changes: - Downgrade go.podman.io/storage to v1.61.1-0.20251111134650-36964d15757a - Downgrade buildah to v1.42.2 - Downgrade podman to v5.7.1 - Upgrade filepath-securejoin to v0.6.1 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/moby/buildkit from 0.25.1 to 0.28.1.
Release notes
Sourced from github.com/moby/buildkit's releases.
... (truncated)
Commits
45b038cgit: normalize and validate subdir pathsf5462c2git: harden ref arg handling71577a5source: extract SafeFileName into shared pathutil packagedf43783source/http: use os.Root for saved file operations9ce6f62source/http: sanitize downloaded filenames099cf80executor: validate container IDs centrally2642113Merge pull request #6610 from thaJeztah/0.28_backport_bump_patternmatcher802da78vendor: github.com/moby/patternmatcher v0.6.15245d86Merge pull request #6551 from tonistiigi/v0.28-cherry-picks90ee5devendor: update x/net to v0.51.0