fix(orchestrator): use versioned name for the DB creation Job to avoid immutable upgrade errors (1.10.1)#427
Open
gustavolira wants to merge 1 commit into
Conversation
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again |
rhdh-qodo-merge
Bot
added
documentation
Member
|
AI summary failed to mention BOTH related issues, so I've added them to the summary and here too: Related issues: |
…d immutable upgrade errors The `<release>-create-sonataflow-database` Job uses a fixed name across chart versions. When a field in the rendered pod spec changes between versions (e.g. the pinned PostgreSQL image digest), an in-place `helm upgrade` of an Orchestrator-enabled release tries to patch the Job's immutable `spec.template` and fails: Job.batch "<release>-create-sonataflow-database" is invalid: spec.template: ... field is immutable Use a versioned name `<release>-create-sf-db-<chart-version>` so each chart version gets a distinct Job (recreated instead of patched). This is the minimal part of redhat-developer#407 needed to fix the upgrade; the fail-hard / configurable backoffLimit changes (RHDHBUGS-2577) are intentionally left out of the 1.10 line. Fixes RHDHBUGS-3325. Targets 1.10.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Gustavo Lira <guga.java@gmail.com>
gustavolira
force-pushed
the
backport-407-release-1.10
branch
from
16aa7f5 to
4fbe981
Compare
gustavolira
changed the title
|
rm3l
approved these changes
Jun 9, 2026
rm3l
left a comment
rm3l
left a comment
Member
There was a problem hiding this comment.
LGTM, but on hold until 1.10.0 is out.
/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Backports only the versioned Job-name change from #407 to
release-1.10(targets 1.10.1).The orchestrator DB-creation Job uses a fixed name
<release>-create-sonataflow-databaseacross chart versions. When any field of the rendered pod spec changes between versions — in practice the pinned PostgreSQL image digest — an in-placehelm upgradeof an Orchestrator-enabled release tries to patch the Job's immutablespec.templateand fails:This is latent: the Job template itself is unchanged between 1.9 and 1.10 — the only differing field is the postgres image digest, so it can affect any upgrade where that digest bumps.
Using a versioned name
<release>-create-sf-db-<chart-version>gives each chart version a distinct Job (recreated instead of patched), avoiding the immutable-field error.Scope
Per discussion, this intentionally includes only the versioned-name change. The fail-hard / configurable
backoffLimit/ TTL changes from #407 (RHDHBUGS-2577) are left out of the 1.10 line on purpose, soactiveDeadlineSeconds,backoffLimitand the psql command are unchanged.How was the change tested?
helm templatewithorchestrator.enabled=truerenders the Job as<release>-create-sf-db-5-12-4.Related