Feature: Add 'Random custom' and 'Custom +1' color options in Auto Color#2020
Open
kkzero84 wants to merge 1 commit into
Open
Feature: Add 'Random custom' and 'Custom +1' color options in Auto Color#2020kkzero84 wants to merge 1 commit into
kkzero84 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new, highly requested coloring options to the Auto Color/Icon/Layout tool. Both options are designed to utilize the user's defined palette in the SWS Color Management window (
g_custColors), providing better thematic consistency for projects.Why are these needed?
Random custom: The existing
Randomoption picks colors from the entire 0-255 RGB spectrum, which often breaks a project's visual theme by applying overly bright or dull colors.Random customrestricts the random selection strictly to the non-empty slots in the user's custom palette.Custom +1 (Sequential): The existing
Customcolor rule simply iterates through the palette using an internal counter (iCount). However, this ignores the actual color of the preceding track, breaking the sequence if tracks are reordered or deleted.Custom +1acts similar to Cubase's sequential coloring feature: it intelligently reads the immediate upper track's color viaGetTrack, locates it in the custom palette, and automatically applies the next valid color in the sequence.What was changed?
AC_RANDOM_CUSTOMandAC_CUSTOM_NEXTto the color types enum."Random custom"and"Custom +1"to the dropdown menu string array (cColorTypes).AutoColorTrack(and relative logic blocks) to handle these new behaviors, safely validating against empty (0) slots ing_custColors.