[WIP] BR: Ensure anchored tempo envelope has set bpm#1738
Draft
frenchy64 wants to merge 8 commits into
Draft
Conversation
frenchy64
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
✅ Build sws 943-master completed (commit 47e9f91966 by @frenchy64) Windows 64-bitWindows 32-bit |
frenchy64
force-pushed
the
issue-1737-move-closest-grid
branch
from
ece4864 to
b1c96a6
Compare
frenchy64
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1737
EDIT: this problem is pervasive to many other SWS/BR commands, a more fundamental fix is probably needed. Any command that anchors to a tempo envelope point without bpm seems to have the "floating point" problem.
I just followed my nose, unclear if I broke any surrounding code because I didn't try it. I also did not pay attention to formatting, will fix that up before merging.
Demo: