Skip to content

fix(icon-generator): handle oversized URLs in onCopyShareUrl #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spokodev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(icon-generator): handle oversized URLs in onCopyShareUrl #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions app/(navigation)/icon/icon-generator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,14 +439,28 @@ export const IconGenerator = () => {
Object.entries(settings).map(([key, value]) => [key, String(value)]),
).toString()}`;

let urlToCopy = url;
const encodedUrl = encodeURIComponent(url);
const response = await fetch(`https://ray.so/api/shorten-url?url=${encodedUrl}&ref=icons`).then((res) =>
res.json(),
);
// The shorten-url endpoint rejects URLs above ~2KB. Custom images get serialized
// into the URL as base64 and blow past that ceiling, which previously left the
// "Copying URL to clipboard…" toast stuck with no error. Skip the shorten step
// for those cases and copy the unshortened URL with a clarifying message.
if (url.length > 2000) {
navigator.clipboard.writeText(url);
showInfoMessage("URL copied (too long to shorten — custom images stay inline)", true);
return;
}

if (response.link) {
urlToCopy = response.link;
let urlToCopy = url;
try {
const encodedUrl = encodeURIComponent(url);
const response = await fetch(`https://ray.so/api/shorten-url?url=${encodedUrl}&ref=icons`);
if (response.ok) {
const data = await response.json();
if (data.link) {
urlToCopy = data.link;
}
}
} catch {
// Network/CORS failure — fall through to the unshortened URL below.
}

navigator.clipboard.writeText(urlToCopy);
Expand Down