Replace Bincode with Postcard#540
Merged
Merged
Conversation
Madoshakalaka
approved these changes
Mar 26, 2026
|
|
||
| ### Version 0.7.0 | ||
|
|
||
| - **BREAKING:** Replace `Bincode` with `Postcard` (#540) by @ranile |
Collaborator
There was a problem hiding this comment.
Looks good!
The breakage is removing the public Bincode type. Anyone who explicitly wrote:
use gloo_worker::Bincode;WorkerSpawner<MyWorker, Bincode>will get a compile error. But in practice, I think nobody does this.
The whole point of the CODEC = Bincode default type parameter is that users never name it.
I think it's worth mentioning.
Owner
Author
There was a problem hiding this comment.
I agree, I'll edit the PR description so anyone following the changelog can see it and include it in commit too
Collaborator
|
Need to edit the version of the root gloo crate in the CHANGELOG to 0.13.0 now though |
Owner
Author
I'll just let the tool from #542 re-generate it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postcard was chosen because it is recommended by the bincode current readme and uses serde instead of custom serialization/deserialization protocol
fixes #529
The breakage is removing the public
Bincodetype. Anyone who explicitly wrote:will get a compile error. But in practice, I think nobody does this.
The whole point of the
CODEC = Bincodedefault type parameter is that users never name it.