-
Notifications
You must be signed in to change notification settings - Fork 35
Matlab syntax and Comment blocks for Matlab and Julia #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JurajLieskovsky
wants to merge
16
commits into
randy3k:master
Choose a base branch
from
JurajLieskovsky:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c7d24c4
Ignore empty lines
JurajLieskovsky 2a273d7
Matlab uses julia syntax
JurajLieskovsky 8e71955
Should match on start of julia comment block "#="
JurajLieskovsky 7ffe6d2
Matches julia comment blocks
JurajLieskovsky 66afbc0
Reverting "ignore empty lines"
JurajLieskovsky 0fd52c5
Reverting "ignore empty lines"
JurajLieskovsky 3fed50e
Reverting "ignore empty lines"
JurajLieskovsky daf3404
Merge remote-tracking branch 'origin/Comment_blocks' into Comment_blocks
JurajLieskovsky 72af9b7
Merge branch 'Comment_blocks' into Matlab_syntax
JurajLieskovsky 1c7e9de
Matlab syntax separated
JurajLieskovsky c62a52c
full matlab syntax
JurajLieskovsky e872a15
Matlab Syntax And Comment Blocks For Matlab And Julia
JurajLieskovsky ca13220
backwards sq bracket matching for Matlab and Julia
JurajLieskovsky 7e164a5
slight correction
JurajLieskovsky 61ef080
fixed comment block recognition
JurajLieskovsky e90f278
Revert of square brackets
JurajLieskovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not very accurate. Imagine we have a string
s = "]".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry didn't realise it would be updating the pull as I make changes to my repository. The square bracket is a work in progress from today.
What is the correct way to do these pull requests? Creating a separate branch for each pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. It is usually a better idea to create a new branch for pull requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But at least in matlab there are no other uses for square brackets than array definitions so solving the issue you raised should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I argue that we shouldn’t allow this though. The code is not readable with that style and you should first run a code formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's actually how I format my matrices most of the time.
I personally want the result to be a live matlab interpreter where I can send commands as I write the file. But I will be happy to keep it in my fork with more brute force algorithms, leaving your elegant code as is.