[runtime] fixup rasterizer#139
Merged
Merged
Conversation
- missing RGBA5551 to RGBA8888 conversion in lookupClut - round depth up for triangles (Code Veronica text bug)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, I round depth up in the triangle rasterizer for Code Veronica instead of truncate
Game expects FFFE for fade draw, but we sometimes produce FFFD for flat depth on triangles which fails the depth test
Stippling in z is still an issue
Small additional oversight is fixed for clut color lookup for 16 bit
Longer-term, triangle rasterization fixes in my rasterizer rework part 2 PR to fix stippling and other errors