Add a memory monitor to the nightly CI#1892
Conversation
Also provide the ability to change the value when running the workflow manually, and print additional debugging information.
This is to reduce the number of possible problems.
mhucka
changed the title
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
mhucka
changed the title
fdmalone
left a comment
fdmalone
left a comment
There was a problem hiding this comment.
not sure of the full context but would it be better to add the memory monitoring before making the other changes in order to measure their effect? Feel free to disregard though.
Yeah, you're right. I'll remove the extra changes before merging it. |
| env: | ||
| # Default value for "-n" argument to pytest with pytest-xdist plugin. | ||
| pytest-n: ${{inputs.processes || 'logical'}} | ||
| pytest-n: ${{inputs.processes || 'auto'}} |
There was a problem hiding this comment.
This sets environment variable named pytest-n which cannot be accessed from a shell. Consider renaming to pytest_n or just use the context expression as is in the uv run command below.
There was a problem hiding this comment.
It's referenced using ${{env.pytest-n}}.
It does seem to work as-is. (Also, note that this env variable is not part of this PR, although the value is being changed.)
The notebook runs seem to be failing – let's try reducing the number of processes.
3 participants
Add a continuous memory & disk space monitor process in the background to report free memory & disk space every 10 seconds.