Skip to content

REF: rely on libpysal for kernels - #123

Merged
jGaboardi merged 6 commits into
mainfrom
kernel
Jul 5, 2026
Merged

REF: rely on libpysal for kernels#123
jGaboardi merged 6 commits into
mainfrom
kernel

Conversation

@martinfleis

@martinfleis martinfleis commented May 28, 2026

Copy link
Copy Markdown
Member

This needs libpysal main + two PRs that are yet to be merged. Keeping as a draft until then. We'll also need to bump libpysal min version once that is released.

Update: This PR removes custom handling of kernels and relies on new functionality from libpysal 4.15. Pinning the minimum to that and removing all the custom code from spml.

@martinfleis

Copy link
Copy Markdown
Member Author

This is now green on dev and waits only for lib release.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (0b4f954) to head (ccc0f8a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   92.39%   92.34%   -0.06%     
==========================================
  Files           6        6              
  Lines         881      849      -32     
==========================================
- Hits          814      784      -30     
+ Misses         67       65       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis
martinfleis marked this pull request as ready for review July 5, 2026 08:07
@martinfleis
martinfleis requested a review from jGaboardi July 5, 2026 08:08
@jGaboardi
jGaboardi merged commit b46387c into main Jul 5, 2026
12 checks passed
@jGaboardi
jGaboardi deleted the kernel branch July 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants