test: Add predict and predict_proba tests for GWLogisticRegression#116
test: Add predict and predict_proba tests for GWLogisticRegression#116jigyasaba wants to merge 13 commits into
Conversation
up# the commit. all clean
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 6 6
Lines 876 876
=======================================
Hits 809 809
Misses 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…or in GWLogisticRegression
ba39f25 to
aeea7bf
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
martinfleis
left a comment
There was a problem hiding this comment.
Thanks, though I am not sure this is needed. We test both predict and predict_proba on base models and subclasses do not alter that code in any way. I would rather try to find a way how to trim our test suite to make it quicker, than adding more models to be trained.
|
You're right that predict and predict_proba are already tested at the base model level. That said, I understand the concern about test suite runtime and redundancy. I'm happy to reduce or simplify these tests |
|
I would just not do anything as these features are already covered by existing tests. |
Summary:
Adds basic test coverage for predict and predict_proba in GWLogisticRegression
Changes:
Notes:
Testing: