-
Notifications
You must be signed in to change notification settings - Fork 21
Add Custom Grid Parameter to Geometry Class and Discretization #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArasuCandassamy
wants to merge
9
commits into
devel
Choose a base branch
from
feature/grid-parameter
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d4d00b0
Add grid parameter to Geometry class and update discretize_space
ArasuCandassamy 8edcd2b
Bug fix
ArasuCandassamy f0f73a3
Add security checks and verify consistency between ncells and the giv…
ArasuCandassamy a21d841
Update tests with grid feature in Geometry class
ArasuCandassamy e47ff5d
Add comprehensive grid security tests to test_discretization_grid.py
ArasuCandassamy e79a11c
Add grid parameter support to discretize_domain function
ArasuCandassamy 8d15fff
Docstring for Geometry.from_topological_domain
ArasuCandassamy bd8d09a
Pass grid as a dictionary
ArasuCandassamy 6e90be7
Apply requested changes
ArasuCandassamy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that these checks should be made directly in the constructor of the
Geometryclass, not here. Here instead you should check that if theknotsare passed, these are consistent withdomain_h.ncellsanddomain_h.grid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed these checks from there and I have put them in
geometry.pywith a function in theGeometryclass:psydac/psydac/cad/geometry.py
Line 338 in 6e90be7