Remove ansi control chars from PR comment message#1231
Merged
Conversation
tgummerer
reviewed
Jul 24, 2024
tgummerer
left a comment
tgummerer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for getting this started! I left a few comments inline.
tgummerer
approved these changes
Jul 24, 2024
| commentMaxCharacter, | ||
| } = config; | ||
|
|
||
| // GitHub limits comment characters to 65535, use lower max to keep buffer for variable values |
Contributor
There was a problem hiding this comment.
❤️ thanks for documenting this!
|
This PR has been shipped in release v5.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulumi action used with
color: alwaysoutput andcomment-on-pr: truelead to ANSI control characters in the Pull Request comment. Reported in #1229 check for details.Special thanks to @bennettp123 who had the idea, converting the output from ansi to html and add html to the comment. I picked up the idea propsed in #859.
Changes proposed in this PR: