Inspect loadbalancer address from Envoy ingress objects#7595
Draft
tsaarni wants to merge 3 commits into
Draft
Conversation
…rojectcontour#4952) Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: Haitao Li <hli@atlassian.com>
4eb607d to
bca643d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7595 +/- ##
==========================================
- Coverage 82.35% 82.14% -0.22%
==========================================
Files 130 130
Lines 15873 15994 +121
==========================================
+ Hits 13073 13138 +65
- Misses 2513 2566 +53
- Partials 287 290 +3
🚀 New features to boost your workflow:
|
d13ccd5 to
eb0780c
Compare
…r-status Signed-off-by: Tero Saarni <tero.saarni@est.tech>
eb0780c to
3c4b453
Compare
Member
Author
|
I am marking this PR as a draft because there is more work to do than I initially anticipated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is continuation of #5987 by @hligit and @kahirokunn.
Contour propagates load balancer addresses to
Ingress/HTTPProxystatus. Currently the address source is always a Service. This PR adds a--load-balancer-statusflag that unifies address source configuration:address:<addr,...>: static addresses (IP or FQDN)service:<namespace>/<name>: watch a Service's LoadBalancer statusingress:<namespace>/<name>: watch an Ingress object's LoadBalancer status (new)Also available as
spec.envoy.loadBalancerin ContourConfiguration CRD orload-balancer-statusin config file.Changes compared to #5987:
hostname:kind toaddress:to support both IP and FQDNTODO
<kind>:<value>only for--load-balancer-statusflag (or simply not support CLI option for ingress at all)Fixes #4952