Sync ext auth server config into envoy when virtualhost authPolicy is disabled

[LittleLittleLittleBoy]

problem

When setting external auth server in virtualhost. Under this virtualhost, there are many service under this virtualhost, and we just want to set up auth server for one service

the root httpproxy:

  virtualhost:
    authorization:
      authPolicy:
        disabled: true
      extensionRef:
        name: authserver
        namespace: projectcontour
      failOpen: true

the route level:

    routes:
    - authPolicy:
        disabled: false

After this config, we found auth service config didn't sync auth server config to envoy when the httpproxy.Spec.VirtualHost.Authorization.disabled==true

From route config Contour support to use route level config overwrite virtualhost or global config.
But it only support when virtualhost is disabled:false, and route disabled:true.

Solution

remove this httpproxy.Spec.VirtualHost.Authorization.disabled==true check to allow contour always sync ext auth server config into envoy. And route can overwrite this disabled flag when aythorization is disbaled in vistualhost .

[github-actions]

Hi @LittleLittleLittleBoy! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (180d62f) to head (3e8e0a6).
⚠️ Report is 73 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7468   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         130      130           
  Lines       15722    15722           
=======================================
  Hits        12868    12868           
  Misses       2571     2571           
  Partials      283      283           

Files with missing lines	Coverage Δ
internal/dag/httpproxy_processor.go	91.41% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 30d of inactivity, lifecycle/stale is applied
• After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[tsaarni]

Hi @LittleLittleLittleBoy, thank you for your contribution and apologies for the delay.

Please add a sign-off to your commit and include a changelog file at changelogs/unreleased/7468-LittleLittleLittleBoy-small.md following this sample.