rm type for default attribute#440
Closed
srsudar wants to merge 1 commit into
Closed
Conversation
1 task
Member
|
Looks like #433 was another attempt (though it also has issues), and we also talked a bit about it here: preactjs/wmr#955 Sorry, discussion is a bit spread out |
Member
|
Superseded by #452 |
Author
|
Thank you! |
Member
|
Certainly let me know if you still have any issues, but fingers crossed that this is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempted fix for this issue on the main preact project:
preactjs/preact#3934
New versions of preact include
SignalLike<boolean>as a valid type for thedefaultattribute. It was suggested by a preact maintainer that thedefaultvalue defined here is unnecessary, as it should match what is provided by preact.