fix: stop rendering skill.md by enumerating Quarto render globs#236
Open
has2k1 wants to merge 1 commit into
Open
fix: stop rendering skill.md by enumerating Quarto render globs#236has2k1 wants to merge 1 commit into
has2k1 wants to merge 1 commit into
Conversation
A recursive "**" in project.render overpowers any "!" negation, so Quarto rendered skill.md -> skill.html despite the !skill.md exclusion. The stray skill.html was then deleted in post-render, which crashed `build --watch` when Quarto tried to hash the missing file (posit-dev#228). Seed project.render with Quarto's default input globs instead of "**" so the !skill.md (and custom-page) exclusions take effect while still matching files recursively. Remove the now-dead post-render workarounds that deleted skill.html and rewrote its links. fixes posit-dev#228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses
skill.mdbeing rendered into the docs site despite the!skill.mdexclusion inproject.render, because a recursive**glob overpowers any!negation that follows it. For example, withrender: ["**", "!skill.md"]Quarto still renderedskill.md→skill.html; a post-render step then deleted that strayskill.html, which crashedgreat-docs build --watchwhen Quarto's file monitor tried to hash the now-missing file (#228).This PR seeds
project.renderwith Quarto's default input globsinstead of
**, so the!skill.mdexclusion — and the analogous custom-page exclusions — actually take effect while still matching files recursively (subdirectory pages likeuser_guide/*.qmdcontinue to render).With
skill.mdno longer rendered, it also removes the now-dead post-render workarounds that deletedskill.htmland rewrote its links, soskill.mdis served directly as a resource and the watch build no longer crashes.fixes #228