Compatibility with localForage#55
Open
insaindesign wants to merge 3 commits into
Open
Conversation
insaindesign
commented
Feb 19, 2022
| } | ||
|
|
||
| const parseState = (toParse: string) => { | ||
| const parseState = (toParse: string | null | undefined): PersistState => { |
Author
There was a problem hiding this comment.
Should change this to PersistItemValue
|
Hello. |
|
Skipping onSet only on the first load as shown below worked as expected, but I am not very confident that it is a good method. |
050c87f to
2f70d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localForageis incompatible withrecoil-storage, return types are different.localForage.getItem()returnsPromise<null|string>. which makes getState return null, as there is no check fornullfrom a promise.localForage.setItem()returnsPromise<string>. butrecoil-storagedoesn't care about that anyway, so doesn't have to enforce those types.Making getState return a Promise always simplifies the code a lot, though that commit doesn't need to be part of this, but it better enforces the types.