Skip to content

fix: prevent atom effect from overwriting state when batching set's#37

Open
bartvanremortele wants to merge 1 commit into
polemius:masterfrom
bartvanremortele:fix/async-batch-set-bug
Open

fix: prevent atom effect from overwriting state when batching set's#37
bartvanremortele wants to merge 1 commit into
polemius:masterfrom
bartvanremortele:fix/async-batch-set-bug

Conversation

@bartvanremortele

Copy link
Copy Markdown

Fixes #35

@polemius

Copy link
Copy Markdown
Owner

Thank you for PR. I have run test against this PR and these two are failing:

Storage: async
    ✕ should remove key from storage if reset (83 ms)
    ✕ should update storage if using atomFamily (16 ms)

Could you please check it?

@insaindesign

Copy link
Copy Markdown

It's a little ugly, but i had a go at fixing this for async storage: insaindesign@0811319.

Note it depends on the changes I had made in https://github.com/polemius/recoil-persist/pull/55/files (all storage to async).

@polemius polemius force-pushed the master branch 2 times, most recently from 050c87f to 2f70d34 Compare May 17, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async/await causes a race condition in React

3 participants