Skip to content

Handle block serializers and deserializers in control panels #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JeffersonBledsoe wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Handle block serializers and deserializers in control panels #1875

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad5c178
See what happens if we just implement IBlocks and add the request obj…
JeffersonBledsoe Jan 29, 2025
9accdba
AQ wrap the fake DX object to fix request-based object access
JeffersonBledsoe Jan 29, 2025
0253fdd
format
JeffersonBledsoe Jan 31, 2025
ea83b4d
Merge branch 'main' into block-handlers-in-control-panels
JeffersonBledsoe Jan 31, 2025
df793b8
changelog
JeffersonBledsoe Jan 31, 2025
53c672c
Merge branch 'main' into block-handlers-in-control-panels
JeffersonBledsoe Sep 24, 2025
23f5a81
Run DXContent and Block serializers in control panel serialization
JeffersonBledsoe Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/1875.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed block deserializers not running for control panel fields @JeffersonBledsoe
8 changes: 6 additions & 2 deletions src/plone/restapi/deserializer/controlpanels/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@
from zope.schema import getFields
from zope.schema.interfaces import ValidationError

from plone.restapi.behaviors import IBlocks
from Acquisition import ImplicitAcquisitionWrapper

@implementer(IDexterityContent)

@implementer(IDexterityContent, IBlocks)
class FakeDXContext:
"""Fake DX content class, so we can re-use the DX field deserializers"""

Expand Down Expand Up @@ -44,6 +47,7 @@ def __call__(self, mask_validation_errors=True):

# Make a fake context
fake_context = FakeDXContext()
wrapped_context = ImplicitAcquisitionWrapper(fake_context, self.context)

for name, field in getFields(self.schema).items():
field_data = schema_data.setdefault(self.schema, {})
Expand All @@ -53,7 +57,7 @@ def __call__(self, mask_validation_errors=True):

if name in data:
deserializer = queryMultiAdapter(
(field, fake_context, self.request), IFieldDeserializer
(field, wrapped_context, self.request), IFieldDeserializer
)

try:
Expand Down