Implement Recycle Bin

[rohnsha0]

ref #2966

[mister-roboto]

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[rohnsha0]

@jenkins-plone-org please run jobs

[rohnsha0]

@jenkins-plone-org please run jobs

[stevepiercy]

This is a great addition! Minor tweaks to messages and news. Thank you!

[stevepiercy]

Changes look good. Let's get a technical review from a senior Plonista.

[petschki]

This is nice, but I'd say this should go into master and 6.2 only as it is a new feature.

EDIT: maybe it could be refactored as a "core-addon" which could be used (optionally) in 6.1 too ?

[pbauer]

This is an interesting solution to the problem that was not covered in https://community.plone.org/t/any-plans-for-an-official-trashcan-in-plone/5440
I have not tested it yet but would like know where you found inspiration or discussed the implementation. I also wonder what stashing the obj in an annotation means for relations and annotations. I would expect that relations are removed and not restored upon restore. Are annotations (e.g. comments) kept in an annotation on the obj stashed in an annotation?

[rohnsha0]

would like know where you found inspiration

I took the inspiration from reading about various other CMS :)

I would expect that relations are removed and not restored upon restore.

the relations are preserved throughout the restoration process... as they're essentially "frozen" in the state they were in at deletion time.

Are annotations (e.g. comments) kept in an annotation on the obj stashed in an annotation?

I was unfortunately unable to make it work on deleted comments. I was working on it since morning.. but somehow wasn't able to!

[rohnsha0]

EDIT: maybe it could be refactored as a "core-addon" which could be used (optionally) in 6.1 too ?

+1

[ale-rt]

All the presentation logic for classic UI (in particular the templates), should go in plone.app.layout.
The code should be structured in such a way that it is convenient to build some Rest API endpoint on it.

I still did not have the time to deeply checked the code.

About the approach taken, from my previous experiences, I like the approach of applying a trashed interface because it is way faster.
This does matter a lot when you have big sites.

[ale-rt]

I would use a z3c.form form here

[rohnsha0]

closed in favour of #4168