Convert ObjModelParser sample parser to ES6 class#8993
Merged
Conversation
Build size reportThis PR does not change the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the sample OBJ model parser (
scripts/parsers/obj-model.js) from the legacy ES5 constructor-function +Object.assign(prototype, …)pattern to an ES6 class. Behavior is unchanged.Changes:
function ObjModelParser+Object.assign(ObjModelParser.prototype, {…})into aclass ObjModelParserwith a constructor andparse/_parseIndicesmethods.var→const/let); loop counters and per-branch locals are now block-scoped.pc.ObjModelParser(the parser is a bare global, never attached topc).Notes:
<script>by the script asset handler. Theloaders/objexample consumes it by bare name (new ObjModelParser(...)), which continues to resolve. The only behavioral difference is thatwindow.ObjModelParseris no longer defined — aclasscreates a global lexical binding rather than awindowproperty — and nothing in the repo relied on it.