fix(element): keep msdfPS chunk version at 2.20#8992
Merged
Conversation
#8990 re-added the font_pxrange uniform and bumped msdfPS to 2.21, but that change is additive: a 2.20-era override that doesn't read font_pxrange just ignores the extra uniform and keeps working. The only overrides that break are pre-2.20 ones (they read the removed font_textureWidth), and those are already flagged by the existing 2.20 marker. 2.20 stays the last breaking change to the chunk, and this keeps main and release-2.20 consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Build size reportThis PR does not change the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8990.
#8990 re-added the
font_pxrangeuniform and bumped themsdfPSchunk version to2.21. That bump isn't needed: the change is additive, so it doesn't break existing overrides.fwidth(sigDist), never declaresfont_pxrange) just ignores the extrasetParameter— PlayCanvas drops parameters with no matching uniform — and keeps working.font_textureWidth, and those are already flagged by the existing'2.20'marker (theirapiVersion < 2.20).So
'2.20'already catches every override that actually breaks;'2.21'would only emit a spurious "please update" warning to 2.20-era authors whose chunks are fine.2.20is the last breaking change to the chunk.This also keeps
msdfPSconsistent betweenmainandrelease-2.20(the #8990 backport deliberately kept'2.20'). Shader/text-elementchanges from #8990 are unaffected — only this one bookkeeping line changes.