Add public app getter to ResourceHandler, mark _app protected#8991
Merged
Conversation
Build size reportThis PR changes the size of the minified bundles.
|
Public API reportThis PR changes the public API surface (+14 / −0), per the docs' rules (@ignore / @Private / undocumented are excluded). Show API diff+AnimationHandler.get app(): AppBase
+AudioHandler.get app(): AppBase
+ContainerHandler.get app(): AppBase
+CubemapHandler.get app(): AppBase
+FontHandler.get app(): AppBase
+MaterialHandler.get app(): AppBase
+ModelHandler.get app(): AppBase
+RenderHandler.get app(): AppBase
+ResourceHandler.get app(): AppBase
+SceneHandler.get app(): AppBase
+ScriptHandler.get app(): AppBase
+SpriteHandler.get app(): AppBase
+TextureAtlasHandler.get app(): AppBase
+TextureHandler.get app(): AppBaseInformational only — this never fails the build. |
mvaligursky
added a commit
that referenced
this pull request
Jun 30, 2026
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceHandlerexposed its internal_appfield on the public API surface because it lacked a visibility tag. This adds a clean publicappgetter and marks the backing field protected.Changes:
appgetter toResourceHandlerthat returns the runningAppBase._appfield@protectedso it no longer leaks into the public API. Subclasses (HierarchyHandler,SceneHandler,ScriptHandler,TemplateHandler) already use it directly, so protected is the correct visibility.API Changes:
ResourceHandler#appgetter, returningAppBase.ResourceHandler#_appis now@protected(it was previously emitted as a public field in the generated type declarations). It was never intended as public API — use the newappgetter instead.