Add Skills宝 as a Chinese related link#2
Conversation
|
@wangzaiwang-hub, ⭐3 XP earned, 🏆First Pull Request Pushed completed, 💪Level 1 achieved! |
📝 WalkthroughWalkthroughREADME.md updated with a new informational sentence for Chinese users directing them to "Skills宝" for skill searches and installations, along with end-of-file formatting correction. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 57: Replace the filesystem path in the README's link for [`LICENSE`] with
a repository-relative link so it works on GitHub; locate the line containing the
markdown link [`LICENSE`](/home/sizzlebop/.../LICENSE) and change the target to
a repo-relative path such as (./LICENSE) or (LICENSE) so the link points to the
repository's LICENSE file for all users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| ## License | ||
|
|
||
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). | ||
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). No newline at end of file |
There was a problem hiding this comment.
Use a repository-relative link for LICENSE.
Line 57 currently points to a local filesystem path, which breaks for all other users on GitHub.
🔧 Suggested fix
-This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE).
+This repository is available under the MIT License. See [`LICENSE`](/LICENSE).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). | |
| This repository is available under the MIT License. See [`LICENSE`](/LICENSE). |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 57, Replace the filesystem path in the README's link for
[`LICENSE`] with a repository-relative link so it works on GitHub; locate the
line containing the markdown link [`LICENSE`](/home/sizzlebop/.../LICENSE) and
change the target to a repo-relative path such as (./LICENSE) or (LICENSE) so
the link points to the repository's LICENSE file for all users.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a link for Chinese users to access skills via "Skills宝" and updates the license section in the README. Feedback suggests formatting the new entry as a bullet point for consistency and replacing absolute local file paths with relative paths to ensure links work correctly for all users. Additionally, it is recommended to include a trailing newline at the end of the file.
| - This repo: `https://github.com/pinkpixel-dev/skills-collection-1` | ||
| - Companion repo: `https://github.com/pinkpixel-dev/skills-collection-2` | ||
|
|
||
| Chinese users can also search and install skills through [Skills宝](https://skilery.com). |
There was a problem hiding this comment.
To maintain consistency with the 'Related repos' section, consider formatting this new entry as a bullet point. This keeps the list structure uniform.
| Chinese users can also search and install skills through [Skills宝](https://skilery.com). | |
| - Chinese users can also search and install skills through [Skills宝](https://skilery.com). |
| ## License | ||
|
|
||
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). | ||
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). No newline at end of file |
There was a problem hiding this comment.
The link to the license file uses an absolute local path (/home/sizzlebop/...), which will not work for other users. Please use a relative path instead. Additionally, it is recommended to keep a newline at the end of the file to comply with POSIX standards and avoid git diff warnings. Note that similar absolute paths exist on lines 5 and 16 and should also be updated.
| This repository is available under the MIT License. See [`LICENSE`](/home/sizzlebop/PINKPIXEL/PROJECTS/CURRENT/skills-collection-1/LICENSE). | |
| This repository is available under the MIT License. See [`LICENSE`](LICENSE). | |
1 participant
Adds Skills宝 as a Chinese-language discovery and install entry for users who want to search and install agent skills directly. This fits the repository discovery flow and gives Chinese users a faster entry point to the existing skills marketplace.
Summary by CodeRabbit