tiproxy: delete drained pods early when the connection drops to zero - #6936
Merged
ti-chi-bot[bot] merged 3 commits intoJun 15, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6936 +/- ##
==========================================
+ Coverage 39.30% 39.40% +0.10%
==========================================
Files 430 430
Lines 24310 24376 +66
==========================================
+ Hits 9554 9606 +52
- Misses 14756 14770 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
/hold |
Member
Author
|
/retest |
YangKeao
marked this pull request as ready for review
June 11, 2026 16:23
Member
Author
|
/retest |
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/unhold |
Member
|
/lgtm |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the connection on a specific tiproxy pod has already dropped to zero, we can delete it earlier. It'll optimize the total time consumed by rolling update / scaling in.