Clean up GLC module: drop solve(), slim results, honest mass balance#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to the GLC/BVP1D refactor (#28).
solve()helper: it duplicated the block's BVP1D-seeding pipeline and nothing called it anymore.update(phys_props)/update(dim_params)merge and unused partial-pressure keys.mass_balance_residual [mol/s]diagnostic. C-C closes to numerical noise (~1e-15); O-C shows the ~0.4% imbalance that the open inlet boundary genuinely leaves, instead of hiding it.Block IO unchanged; C-C output ports bit-identical to before. Tests updated accordingly (tritium suite green).