Skip to content

Clean up GLC module: drop solve(), slim results, honest mass balance#29

Merged
milanofthe merged 1 commit into
mainfrom
cleanup/glc-remove-solve
Jun 25, 2026
Merged

Clean up GLC module: drop solve(), slim results, honest mass balance#29
milanofthe merged 1 commit into
mainfrom
cleanup/glc-remove-solve

Conversation

@milanofthe

Copy link
Copy Markdown
Member

Follow-up cleanup to the GLC/BVP1D refactor (#28).

  • Remove the orphaned standalone solve() helper: it duplicated the block's BVP1D-seeding pipeline and nothing called it anymore.
  • Slim the results dict from ~33 keys to 11 by dropping the blind update(phys_props)/update(dim_params) merge and unused partial-pressure keys.
  • Replace the mass-balance fudge (which redistributed the residual back into the outputs to force closure) with an honest mass_balance_residual [mol/s] diagnostic. C-C closes to numerical noise (~1e-15); O-C shows the ~0.4% imbalance that the open inlet boundary genuinely leaves, instead of hiding it.

Block IO unchanged; C-C output ports bit-identical to before. Tests updated accordingly (tritium suite green).

@milanofthe milanofthe merged commit 4d89f26 into main Jun 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant