Skip to content

⚡ Bolt: [performance improvement] Replace Array.includes with Set in filters for O(N) lookups #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xb1g wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

⚡ Bolt: [performance improvement] Replace Array.includes with Set in filters for O(N) lookups #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/api/assignments/[id]/nodes/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,9 @@ export async function POST(
}

const existingNodeIds = existingNodes?.map((n) => n.id) || [];
const missingNodes = node_ids.filter((id) => !existingNodeIds.includes(id));
// Optimization: Use Set for O(1) lookups instead of Array.includes which is O(N)
const existingNodeIdsSet = new Set(existingNodeIds);
const missingNodes = node_ids.filter((id) => !existingNodeIdsSet.has(id));

if (missingNodes.length > 0) {
return NextResponse.json(
Expand Down
4 changes: 3 additions & 1 deletion app/api/classrooms/[id]/grading/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,9 @@ export async function GET(

// Get additional profiles for members not in submissions
const classroomUserIds = classroomMembers.map(m => m.user_id);
const missingUserIds = classroomUserIds.filter(id => !submissionUserIds.includes(id));
// Optimization: Use Set for O(1) lookups instead of Array.includes which is O(N)
const submissionUserIdsSet = new Set(submissionUserIds);
const missingUserIds = classroomUserIds.filter(id => !submissionUserIdsSet.has(id));

let additionalProfiles: any[] = [];
if (missingUserIds.length > 0) {
Expand Down
4 changes: 3 additions & 1 deletion components/teams/StudentTeamDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ export function StudentTeamDashboard({

// Find available teams (teams user is NOT in)
const userTeamIds = userTeams.map((t) => t.id);
const availableTeams = allTeams.filter((t) => !userTeamIds.includes(t.id));
// Optimization: Use Set for O(1) lookups instead of Array.includes which is O(N)
const userTeamIdsSet = new Set(userTeamIds);
const availableTeams = allTeams.filter((t) => !userTeamIdsSet.has(t.id));

// Get teams with open spots
const teamsWithOpenSpots = availableTeams.filter(
Expand Down