Blur Integration - #371
Open
zhoujia6139 wants to merge 42 commits into
Open
Conversation
zhoujia6139
marked this pull request as draft
April 15, 2023 03:57
zhoujia6139
marked this pull request as ready for review
April 17, 2023 13:33
i5possible
reviewed
Apr 18, 2023
WalidOfNow
reviewed
Apr 20, 2023
| } | ||
|
|
||
| /// @inheritdoc IPoolParameters | ||
| function enableBlurExchange() external onlyPoolAdmin { |
Contributor
There was a problem hiding this comment.
I suggest using different names for these. as we are not really enabling the actual exchange
| request.borrowAmount, | ||
| timeLockParams | ||
| ); | ||
| IWETH(weth).withdraw(request.borrowAmount); |
Contributor
There was a problem hiding this comment.
can't we transfer weth directly? might save us one transfer
0x8f701
reviewed
Apr 21, 2023
WalidOfNow
reviewed
Apr 24, 2023
jefmono
reviewed
Apr 25, 2023
jefmono
reviewed
Apr 25, 2023
billyz9611
reviewed
May 29, 2023
| // currency token. address(0) means ETH | ||
| address paymentToken; | ||
| // cash amount from user wallet | ||
| uint256 listingPrice; |
| Errors.INVALID_REQUEST_STATUS | ||
| ); | ||
|
|
||
| address keeper = ps._blurExchangeKeeper; |
There was a problem hiding this comment.
could we not to check “msg.sender == keeper” to save some gas.
| address nTokenAddress = nftReserve.xTokenAddress; | ||
| // no time lock needed here | ||
| DataTypes.TimeLockParams memory timeLockParams; | ||
| (, uint64 collateralizedBalance) = INToken(nTokenAddress).burn( |
There was a problem hiding this comment.
if the nToken is in auction , will revert.
| .getParams(); | ||
| // ensure user can't borrow/withdraw with the new mint nToken | ||
| require( | ||
| request.listingPrice >= floorPrice.percentMul(liquidationThreshold), |
There was a problem hiding this comment.
- user init buy from blur which have high boost token id (set require.listingprice = nToken floor price * LS)
- user get more borrow limit : nToken floor price * boost *LTV - nToken floor price * LS
- user can borrow more money.
|
|
||
| //mint debt token | ||
| if (totalBorrow > 0) { | ||
| BorrowLogic.executeBorrow( |
There was a problem hiding this comment.
should we do transferUnderlyingTo before executeBorrow ? since the borrow use rate is not correct in updateInterestRates now.
borrow use rate = total debt / (balance (pToken contract) + total debt)
balance (pToken contract) should subtract the totalBorrow
billyz9611
reviewed
May 30, 2023
| request.tokenId | ||
| ); | ||
|
|
||
| return request.listingPrice + requestFee - request.borrowAmount; |
There was a problem hiding this comment.
Can we save some gas if calculate needCashETH first and sent into validateInitiateBlurExchangeRequest ?
billyz9611
reviewed
May 31, 2023
* chore: basic implementation for BLUR sell * chore: fix typo * chore: check ape pair staking and gas optimization * chore: check owner and fix interest rate issue * chore: keeper fulfill request with ETH * chore: fix updating wrong status * chore: forbid initiate request for uniswapV3 and stakeFish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Checklist
Make sure to think about each of these exploits in this PR.