feat(agents): add post-generation language/style check to personal-create-pr#482
Merged
Merged
Conversation
p-chan
force-pushed
the
add-post-generation-check-to-personal-create-pr
branch
from
a1f539d to
904f9cf
Compare
p-chan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After generating a PR title and body, there was no step to verify that the output matched the judged language and style. This caused the agent to inadvertently write the body in Japanese despite the convention being English.
What
Added a post-generation verification table to step 5 of
personal-create-prSKILL.md. After generating the title and body, the agent outputs a table comparing the expected values (language, style, template) against the actual output, and corrects any mismatches.Notes
None