Skip to content

Pin toolchain in actions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-be-dev merged 17 commits into from
Jan 10, 2022
Merged

Pin toolchain in actions #139

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0144811
Pin toolchain in actions
smklein Oct 13, 2021
ac4441c
Update actions-rs, set default=true
smklein Oct 13, 2021
16abb42
Show rustc version
smklein Oct 13, 2021
6ad7b98
Add Cargo.lock, rust-toolchain, update output
smklein Oct 13, 2021
d434044
Merge branch 'main' into pin-toolchain
just-be-dev Jan 8, 2022
a7e81fe
update to latest stable toolchain
just-be-dev Jan 8, 2022
32842eb
Remove toolchain version from action in favor of toolchain file
just-be-dev Jan 8, 2022
82e875d
Drop rust-toolchain's .toml extension until action-rs supports it
just-be-dev Jan 8, 2022
ef24cd8
Use forked toolchain action
just-be-dev Jan 8, 2022
d8b1a28
Update fork, add comment about upstream PR
just-be-dev Jan 8, 2022
1c8c22a
Update fork again
just-be-dev Jan 8, 2022
74cd8ce
Merge branch 'main' into pin-toolchain
just-be-dev Jan 10, 2022
2ae9578
Merge branch 'main' into pin-toolchain
just-be-dev Jan 10, 2022
88e74c2
Switch to oxide's fork
just-be-dev Jan 10, 2022
3f0dff6
Update doc block as suggested in PR review
just-be-dev Jan 10, 2022
cfef63d
Fix typo
just-be-dev Jan 10, 2022
c5161c1
Add some details to maintainers about renovate
just-be-dev Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 36 additions & 37 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,56 +5,55 @@ name: Rust

on:
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

jobs:
check-style:
runs-on: ubuntu-18.04
steps:
# actions/checkout@v2
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
- uses: actions-rs/toolchain@88dc2356392166efad76775c878094f4e83ff746
with:
toolchain: nightly-2021-03-25
default: false
components: rustfmt
- name: Report cargo version
run: cargo +nightly-2021-03-25 --version
- name: Report rustfmt version
run: cargo +nightly-2021-03-25 fmt -- --version
- name: Check style
run: cargo +nightly-2021-03-25 fmt -- --check
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
- uses: actions-rs/toolchain@88dc2356392166efad76775c878094f4e83ff746
with:
toolchain: nightly-2021-03-25
default: false
components: rustfmt
- name: Report cargo version
run: cargo +nightly-2021-03-25 --version
- name: Report rustfmt version
run: cargo +nightly-2021-03-25 fmt -- --version
- name: Check style
run: cargo +nightly-2021-03-25 fmt -- --check

clippy-lint:
runs-on: ubuntu-18.04
steps:
# actions/checkout@v2
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
- name: Report cargo version
run: cargo --version
- name: Report Clippy version
run: cargo clippy -- --version
- name: Run Clippy Lints
run: cargo clippy -- -D warnings
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
- name: Report cargo version
run: cargo --version
- name: Report Clippy version
run: cargo clippy -- --version
- name: Run Clippy Lints
run: cargo clippy -- -D warnings

build-and-test:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-18.04, windows-2019, macos-10.15 ]
os: [ubuntu-18.04, windows-2019, macos-10.15]

@davepacheco davepacheco Jan 10, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a lot of this file was reformatted and that makes it a little harder to view the diffs.

@just-be-dev just-be-dev Jan 10, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, sorry about that. I'll revert those changes.

@just-be-dev just-be-dev Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one note: You can hide whitespace changes in diffs

image

I usually have that enabled which is probably why I didn't noticed the formatting diffs.

(I'll still revert them though)

steps:
# actions/checkout@v2
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
- uses: actions-rs/toolchain@88dc2356392166efad76775c878094f4e83ff746
with:
profile: minimal
toolchain: stable
override: true
- name: Report cargo version
run: cargo --version
- name: Build
run: cargo build --locked --all-targets --verbose
- name: Run tests
run: cargo test --locked --verbose
- uses: actions/checkout@230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7
# Temporary fork until https://github.com/actions-rs/toolchain/pull/209 is merged
Comment thread
just-be-dev marked this conversation as resolved.
- uses: oxidecomputer/action-rs_toolchain@ad3f86084a8a5acf2c09cb691421b31cf8af7a36
with:
profile: minimal
override: true
- name: Report cargo version
run: cargo --version
- name: Report rustc version
run: rustc --version
- name: Build
run: cargo build --locked --all-targets --verbose
- name: Run tests
run: cargo test --locked --verbose
7 changes: 7 additions & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# We use a specific toolchain revision to ensure our tests - which
# occasionally depend on specific compiler output - remain stable
# for all developers until the toolchain is explicitly advanced.
Comment thread
just-be-dev marked this conversation as resolved.

[toolchain]
channel = "1.57.0"
profile = "default"