northd, ovn-sbctl: Fix null pointer dereferences in sbrec delete calls.#301
Open
oilbeater wants to merge 1 commit into
Open
northd, ovn-sbctl: Fix null pointer dereferences in sbrec delete calls.#301oilbeater wants to merge 1 commit into
oilbeater wants to merge 1 commit into
Conversation
Add missing NULL checks before calling sbrec delete functions to prevent null pointer dereferences: - en-sync-sb.c: Add missing 'continue' after free(sb_lb) in sync_changed_lbs() to avoid use-after-free when accessing sb_lb->sbrec_lb in the subsequent sync_sb_lb_record() call. - northd.c: Add NULL check for op->sb before calling sbrec_port_binding_delete() in ls_handle_lsp_changes(). - northd.c: Add NULL check for bfd_e->sb_bt before calling sbrec_bfd_delete() in bfd_table_sync(). - ovn-sbctl.c: Add NULL check for encaps[i] before calling sbrec_encap_delete() in cmd_chassis_del(). Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Collaborator
|
Hi, We use mailing list to submit patches https://docs.ovn.org/en/latest/internals/contributing/submitting-patches.html. Each of the changes should be a separate commit with proper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We experienced some segmentation faults in our end-to-end tests, and with these patches, the segmentation fault has been resolved.
Add missing NULL checks before calling sbrec delete functions to prevent null pointer dereferences: