refactor: decompose Rust build-pipeline process_file and match_js_type_map#1592
Merged
Conversation
… DEFAULTS docs check acknowledged
4 tasks
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+698
to
+702
| // Engine selection: CODEGRAPH_ENGINE env always wins over config-file value. | ||
| if (process.env.CODEGRAPH_ENGINE !== undefined) { | ||
| const val = process.env.CODEGRAPH_ENGINE as 'auto' | 'native' | 'wasm'; | ||
| (config.build as Record<string, unknown>).engine = val; | ||
| } |
Contributor
There was a problem hiding this comment.
CODEGRAPH_ENGINE value is cast to the union type without any runtime validation. If the variable is set to an unrecognized value (e.g. CODEGRAPH_ENGINE=typo), it will be written to config undetected and could silently cause the engine-selection logic downstream to behave unexpectedly. The CODEGRAPH_FAST_SKIP_DIAG path uses an explicit === '1' check, which is a safer pattern for this kind of single-source-of-truth override.
Suggested change
| // Engine selection: CODEGRAPH_ENGINE env always wins over config-file value. | |
| if (process.env.CODEGRAPH_ENGINE !== undefined) { | |
| const val = process.env.CODEGRAPH_ENGINE as 'auto' | 'native' | 'wasm'; | |
| (config.build as Record<string, unknown>).engine = val; | |
| } | |
| // Engine selection: CODEGRAPH_ENGINE env always wins over config-file value. | |
| if (process.env.CODEGRAPH_ENGINE !== undefined) { | |
| const val = process.env.CODEGRAPH_ENGINE; | |
| if (val === 'auto' || val === 'native' || val === 'wasm') { | |
| (config.build as Record<string, unknown>).engine = val; | |
| } else { | |
| debug(`applyEnvOverrides: ignoring unknown CODEGRAPH_ENGINE value "${val}" (expected auto|native|wasm)`); | |
| } | |
| } |
Contributor
Author
There was a problem hiding this comment.
Resolved — merged origin/main which brings in CODEGRAPH_ENGINE and CODEGRAPH_FAST_SKIP_DIAG test coverage from #1589. Additionally, the merge also brings in main's validation-with-warning for CODEGRAPH_ENGINE (the P2 finding itself): invalid values now log a warning and fall back to "auto" rather than being cast blindly.
Contributor
Codegraph Impact Analysis23 functions changed → 27 callers affected across 4 files
|
Keep main's validation-with-warning for CODEGRAPH_ENGINE and the detailed JSDoc for config.build.engine referencing issue #1596.
Contributor
Author
|
Addressed Greptile finding: merged origin/main to pick up env-override test coverage for CODEGRAPH_ENGINE and CODEGRAPH_FAST_SKIP_DIAG (landed in #1589). The merge also brings in the validation-with-warning fix for CODEGRAPH_ENGINE (the P2 finding itself) — invalid values now warn and fall back to "auto". All 3126 tests pass locally. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the TS call-resolution decomposition (PR #1591) for the Rust native engine. Decomposes the highest-complexity Rust functions in the build pipeline.
process_file: cog 73→14, bugs 3.72→0.69 (81% reduction each)match_js_type_map: cog 122→thin dispatcher (~95% reduction)write_dataflowinpipeline.rs: extracted focused helperdo_insert_nodesininsert_nodes.rs: decomposedTitan Audit Context
Changes
crates/codegraph-core/src/domain/graph/builder/stages/build_edges.rs—process_filedecomposed into focused sub-functions;match_js_type_map→ thin dispatchercrates/codegraph-core/src/extractors/javascript.rs—match_js_type_maphelpers extractedcrates/codegraph-core/src/domain/graph/builder/pipeline.rs—write_dataflowextractedcrates/codegraph-core/src/domain/graph/builder/stages/insert_nodes.rs—do_insert_nodesdecomposedMetrics Impact
process_file(Rust): cog 73→14, bugs 3.72→0.69match_js_type_map(Rust): cog 122→dispatcher patternTest plan