Skip to content

eliminate model package; converging on declcfg#2025

Open
grokspawn wants to merge 3 commits into
operator-framework:masterfrom
grokspawn:model-to-declcfg
Open

eliminate model package; converging on declcfg#2025
grokspawn wants to merge 3 commits into
operator-framework:masterfrom
grokspawn:model-to-declcfg

Conversation

@grokspawn

Copy link
Copy Markdown
Contributor

Description of the change:
builds on #1986 but changes from a separate commit into a separate PR instead. This branches from it, so it includes #1986 content in this PR (and will get simpler if/once #1986 merges and is rebased).

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copilot AI review requested due to automatic review settings June 29, 2026 21:14
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Signed-off-by: grokspawn <jordan@nimblewidget.com>
Signed-off-by: grokspawn <jordan@nimblewidget.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.62190% with 233 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.57%. Comparing base (e79d272) to head (8e66621).

Files with missing lines Patch % Lines
alpha/declcfg/api_conversions.go 35.22% 161 Missing and 10 partials ⚠️
alpha/declcfg/validate.go 94.42% 8 Missing and 6 partials ⚠️
alpha/action/render.go 61.29% 11 Missing and 1 partial ⚠️
alpha/action/list.go 90.09% 2 Missing and 8 partials ⚠️
pkg/cache/cache.go 65.21% 4 Missing and 4 partials ⚠️
pkg/cache/pkgs.go 82.60% 4 Missing and 4 partials ⚠️
alpha/declcfg/declcfg.go 66.66% 3 Missing and 3 partials ⚠️
alpha/action/init.go 91.30% 2 Missing ⚠️
alpha/template/substitutes/substitutes.go 50.00% 0 Missing and 1 partial ⚠️
pkg/lib/config/validate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
- Coverage   58.81%   55.57%   -3.24%     
==========================================
  Files         141       97      -44     
  Lines       13430     8066    -5364     
==========================================
- Hits         7899     4483    -3416     
+ Misses       4322     3032    -1290     
+ Partials     1209      551     -658     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants