UCP/EP: Exclude debug endpoint flags from release builds#11515
Open
tvegas1 wants to merge 3 commits into
Open
Conversation
Member
|
Can we instead define the debug flags to 0 in release build? |
Contributor
Author
Proposal is to prevent using them erroneously on release build completely. They are already inoperative on release build, as they are above the storage 16-bit limit. Setting them to zero would not fix the erroneous usage afaict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Define debug-only EP flags only when assertions are enabled and update them through a debug-only helper.
Why?
Release EP flags are 16-bit, so debug bits 16+ should not be used there or anywhere else.
How?
Make debug flag names assertion-only and compile their updates to no-ops in release builds.